Hi, @realshuting

Please review & help with your approval. TIA

PR Updated ✅ @realshuting

Is #951 relevant?

My bad. I have updated the comment.

Congratulations! 🎉

Great job merging your first Pull Request here! How awesome! If you are new to this project, feel free to join our Slack community.

@realshuting, @nikhilmaheshwari24: changes should not have been made here as these Markdown files are rendered from the contents of the policy library (kyverno/policies). We run a rendering program to then convert to Markdown. These changes will be wiped unless the corresponding policies in the library are updated.

The changes made are also incorrect as without conditionals it will cause all Pods to fail if they don't have initContainers or ephemeralContainers.

changes should not have been made here as these Markdown files are rendered from the contents of the policy library (kyverno/policies). We run a rendering program to then convert to Markdown. These changes will be wiped unless the corresponding policies in the library are updated.

@chipzoller,

• Should I revert the PR changes and raise a new PR in kyverno/policies to update the corresponding policy in the library?
• Or should I fix the changes here as well and raise a new PR in kyverno/policies to update the corresponding policy in the library?

Policy Path - https://github.com/kyverno/policies/blob/main/best-practices/require-pod-requests-limits/require-pod-requests-limits.yaml

I'd just open the PR on kyverno/policies. We'll render policies for the website and pick up those changes.

If you haven't raised the PR, let me do it, I want to contribute.

@realshuting, @nikhilmaheshwari24: changes should not have been made here as these Markdown files are rendered from the contents of the policy library (kyverno/policies). We run a rendering program to then convert to Markdown. These changes will be wiped unless the corresponding policies in the library are updated.

I was not aware of that, thanks for pointing it out.

@nikhilmaheshwari24 - let's open a PR in kyverno/policies with the revised policy, thanks.

@realshuting - PR kyverno/policies#1103